fix(access): exchange oidc tokens for platform jwt sessions#105
fix(access): exchange oidc tokens for platform jwt sessions#105Agent-Hellboy merged 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements OIDC-based authentication, adding a new /api/auth/oidc endpoint to the API service and updating the UI service to exchange OIDC ID tokens for platform access tokens. The changes include new login handlers, user resolution logic, and comprehensive tests. Feedback suggests improving audit logs for failed logins by extracting identity information from the token, avoiding fragile hardcoded URLs in internal dummy requests, and eliminating redundant database lookups in the user resolution process.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52695da3dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 57.15% 57.27% +0.11%
==========================================
Files 59 59
Lines 10448 10476 +28
==========================================
+ Hits 5972 6000 +28
Misses 3905 3905
Partials 571 571
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1 participant
fixes #102